fix: replace ReactDOM.render with createRoot for React 18 compatibility #16292
+116
?70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
Zaid0412
force-pushed
the
fix/use-createRoot
branch
from
dc65a41 to
4007da6
Compare
saghul
reviewed
Aug 4, 2025
| ReactDOM.unmountComponentAtNode(presenceLabelContainer); | ||
| if (this._presenceLabelRoot) { | ||
| this._presenceLabelRoot.unmount(); | ||
| delete this._presenceLabelRoot; |
| ); | ||
| }); | ||
|
|
||
| // No need to unmount with ReactDOM.render in this context, so this can be removed or left empty. |
There was a problem hiding this comment.
Why don't we need to unmount here?
react/index.web.js
Outdated
| ReactDOM.render( | ||
| <Component { ...props } />, | ||
| document.getElementById(elementId) | ||
| const root = createRoot(document.getElementById(elementId)); |
There was a problem hiding this comment.
Should the root be stored somewhere?
|
Jenkins please test this please. |
Zaid0412
force-pushed
the
fix/use-createRoot
branch
2 times, most recently
from
5ed0cb2 to
f16eeb5
Compare
Fix Lint FIx Lint
Zaid0412
force-pushed
the
fix/use-createRoot
branch
from
f16eeb5 to
3d9f6cc
Compare
|
Jenkins please test this please. |
1 similar comment
|
Jenkins please test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces deprecated usage of
ReactDOM.renderwithReactDOM.createRootto make the app compatible with React 18.Why
React 18 no longer supports
ReactDOM.render. Continuing to use it causes the following warning:What Changed
ReactDOM.render(...)to useReactDOM.createRoot(...)root.unmount()where needed